Removed unnecessary comment

README.md

@@ -3,7 +3,7 @@
 # ![Logo](https://i.imgur.com/ktkHND1.png)
 
 This mod is FAR FROM FINISHED, and initially just created for our private Survival Server.
-As a challenge I'm trying to make it as user-friendly as possible. (It ain't there yet tho ;) )
+As a challenge I'm trying to make it as user-friendly as possible.
 # Current feature-set
 
 ## Server Side
@@ -38,7 +38,10 @@ As a challenge I'm trying to make it as user-friendly as possible. (It ain't the
 ## Server Side
 - [x] Chat Calculator
 
+
 ## Client Side
+
+### New Features
 - [x] Teleportation Angle Viewer for [this machine](https://www.youtube.com/watch?v=FnUE-ZaALLw)
 ![Teleportation Keybindings](https://i.imgur.com/gjO1H3d.png)
 - [x] Removed game fog (lava, water, etc.)
@@ -48,8 +51,18 @@ As a challenge I'm trying to make it as user-friendly as possible. (It ain't the
 - [x] Removed darkness effect
   - [x] Toggleable
 
+### Changes
+- Shared Ender Chest
+  - [x] Open/close EC block while opening/closing SEC
+  - [x] Play open & close sounds
+
 # Features to come
 
+## General
+- Rework config system
+  - Store server settings in world folder for better singleplayer use
+  - Rework Mod Menu integration to be more flexible
+
 ## Server Side
 - Telekinesis
 

src/client/java/wtf/hak/survivalfabric/mixin/client/BackgroundRendererMixin.java

@@ -8,6 +8,7 @@ import net.minecraft.client.render.FogShape;
 import net.minecraft.world.World;
 import org.joml.Vector4f;
 import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.Unique;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Inject;
 import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
@@ -17,6 +18,9 @@ import static wtf.hak.survivalfabric.config.client.ClientConfigManager.getConfig
 @Mixin(value = BackgroundRenderer.class, priority = 910)
 public abstract class BackgroundRendererMixin {
 
+    @Unique
+    private static final Fog EMPTY_FOG = new Fog(-8.0f, 1_000_000.0F, FogShape.CYLINDER, 0, 0, 0, 0);
+
     @Inject(method = "applyFog", at = @At("RETURN"), cancellable = true)
     private static void applyFog(Camera camera, BackgroundRenderer.FogType fogType, Vector4f color, float viewDistance, boolean thickenFog, float tickProgress, CallbackInfoReturnable<Fog> cir) {
         boolean renderFog = true;
@@ -37,6 +41,6 @@ public abstract class BackgroundRendererMixin {
             renderFog = false;
 
         if (!renderFog)
-            cir.setReturnValue(new Fog(-8.0f, 1_000_000.0F, FogShape.CYLINDER, 0,0,0,0));
+            cir.setReturnValue(EMPTY_FOG);
     }
 }

src/client/java/wtf/hak/survivalfabric/modmenu/ConfigScreen.java

@@ -55,7 +55,6 @@ public class ConfigScreen extends Screen {
             }
         }
 
-        // Done button
         this.addDrawableChild(ButtonWidget.builder(
                 Text.translatable("gui.done"),
                 button -> this.client.setScreen(parent)

src/main/java/wtf/hak/survivalfabric/SurvivalFabric.java

@@ -1,7 +1,6 @@
 package wtf.hak.survivalfabric;
 
 import net.fabricmc.api.ModInitializer;
-
 import net.fabricmc.fabric.api.command.v2.CommandRegistrationCallback;
 import net.fabricmc.fabric.api.event.lifecycle.v1.ServerEntityEvents;
 import net.fabricmc.fabric.api.event.player.PlayerBlockBreakEvents;
@@ -11,8 +10,8 @@ import org.slf4j.LoggerFactory;
 import wtf.hak.survivalfabric.commands.ReloadConfigCommand;
 import wtf.hak.survivalfabric.commands.SlimeChunkCommand;
 import wtf.hak.survivalfabric.commands.SpectatorCommand;
-import wtf.hak.survivalfabric.sharedenderchest.SharedEnderChest;
-import wtf.hak.survivalfabric.veinminer.VeinMinerEvents;
+import wtf.hak.survivalfabric.features.sharedenderchest.SharedEnderChest;
+import wtf.hak.survivalfabric.features.veinminer.VeinMinerEvents;
 
 import static wtf.hak.survivalfabric.config.ConfigManager.getConfig;
 
@@ -24,9 +23,9 @@ public class SurvivalFabric implements ModInitializer {
 
     @Override
     public void onInitialize() {
-		CommandRegistrationCallback.EVENT.register((dispatcher, registryAccess, environment) -> SpectatorCommand.register(dispatcher, new String[] { "spectator", "s", "S", "camera", "c", "C", }));
-		CommandRegistrationCallback.EVENT.register((dispatcher, registryAccess, environment) -> ReloadConfigCommand.register(dispatcher, new String[] { "reloadsurvivalconfig" }));
-		CommandRegistrationCallback.EVENT.register((dispatcher, registryAccess, environment) -> SlimeChunkCommand.register(dispatcher, new String[] { "slimechunk", "sc" }));
+        CommandRegistrationCallback.EVENT.register((dispatcher, registryAccess, environment) -> SpectatorCommand.register(dispatcher, "spectator", "s", "S", "camera", "c", "C"));
+        CommandRegistrationCallback.EVENT.register((dispatcher, registryAccess, environment) -> ReloadConfigCommand.register(dispatcher, "reloadsurvivalconfig"));
+        CommandRegistrationCallback.EVENT.register((dispatcher, registryAccess, environment) -> SlimeChunkCommand.register(dispatcher, "slimechunk", "sc"));
 
         if (getConfig().sharedEnderChestEnabled)
             new SharedEnderChest().onInitialize();
@@ -35,8 +34,7 @@ public class SurvivalFabric implements ModInitializer {
             PlayerBlockBreakEvents.BEFORE.register((world, player, pos, state, blockEntity) -> {
                 if (player instanceof ServerPlayerEntity serverPlayer) {
                     return VeinMinerEvents.beforeBlockBreak(world, serverPlayer, pos, state);
-				}
-				else {
+                } else {
                     return true;
                 }
             });

src/main/java/wtf/hak/survivalfabric/commands/SlimeChunkCommand.java

@@ -6,11 +6,9 @@ import net.minecraft.server.command.CommandManager;
 import net.minecraft.server.command.ServerCommandSource;
 import net.minecraft.server.network.ServerPlayerEntity;
 import net.minecraft.text.Text;
-import net.minecraft.util.math.random.CheckedRandom;
 import net.minecraft.util.math.random.ChunkRandom;
 import net.minecraft.util.math.random.Random;
 import net.minecraft.world.chunk.Chunk;
-import wtf.hak.survivalfabric.config.ConfigManager;
 
 import static wtf.hak.survivalfabric.config.ConfigManager.getConfig;
 

src/main/java/wtf/hak/survivalfabric/commands/SpectatorCommand.java

@@ -8,7 +8,7 @@ import net.minecraft.server.network.ServerPlayerEntity;
 import net.minecraft.server.world.ServerWorld;
 import net.minecraft.text.Text;
 import net.minecraft.world.GameMode;
-import wtf.hak.survivalfabric.utils.Utils;
+import wtf.hak.survivalfabric.utils.PacketUtils;
 
 import java.util.HashMap;
 import java.util.Map;
@@ -36,7 +36,7 @@ public class SpectatorCommand {
             player.teleport(data.world, data.x, data.y, data.z, Set.of(), data.yaw, data.pitch, false);
             player.changeGameMode(GameMode.SURVIVAL);
             spectating.remove(player);
-            Utils.updateListNames(player);
+            PacketUtils.updateListNames(player);
         } else {
 
             spectating.put(player, new LocationData(player
@@ -47,7 +47,7 @@ public class SpectatorCommand {
                     .getPitch(), player
                     .getServerWorld()));
             player.changeGameMode(GameMode.SPECTATOR);
-            Utils.updateListNames(player);
+            PacketUtils.updateListNames(player);
         }
         return 1;
     }

src/main/java/wtf/hak/survivalfabric/features/sharedenderchest/SharedEnderChest.java

@@ -1,15 +1,9 @@
-package wtf.hak.survivalfabric.sharedenderchest;
+package wtf.hak.survivalfabric.features.sharedenderchest;
 
-import java.io.DataInputStream;
-import java.io.DataOutputStream;
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileOutputStream;
-
-import net.fabricmc.fabric.api.event.player.UseBlockCallback;
 import net.fabricmc.fabric.api.event.lifecycle.v1.ServerLifecycleEvents;
 import net.fabricmc.fabric.api.event.lifecycle.v1.ServerTickEvents;
-
+import net.fabricmc.fabric.api.event.player.UseBlockCallback;
+import net.minecraft.block.Blocks;
 import net.minecraft.block.EnderChestBlock;
 import net.minecraft.entity.player.PlayerEntity;
 import net.minecraft.inventory.Inventories;
@@ -23,11 +17,14 @@ import net.minecraft.server.MinecraftServer;
 import net.minecraft.sound.SoundCategory;
 import net.minecraft.sound.SoundEvents;
 import net.minecraft.text.Text;
-import net.minecraft.util.*;
+import net.minecraft.util.ActionResult;
+import net.minecraft.util.WorldSavePath;
 import net.minecraft.util.collection.DefaultedList;
 import net.minecraft.util.math.BlockPos;
 import net.minecraft.world.World;
 
+import java.io.*;
+
 import static wtf.hak.survivalfabric.SurvivalFabric.LOGGER;
 import static wtf.hak.survivalfabric.config.ConfigManager.getConfig;
 
@@ -37,6 +34,51 @@ public class SharedEnderChest implements ServerLifecycleEvents.ServerStopping, S
 
     private long ticksUntilSave = -20;
 
+    public static void saveInventory(MinecraftServer server) {
+        File inventoryFile = getFile(server);
+        NbtCompound nbt = new NbtCompound();
+        DefaultedList<ItemStack> inventoryItemStacks = DefaultedList.ofSize(getConfig().sharedEnderChestRows * 9, ItemStack.EMPTY);
+        Inventories.writeNbt(nbt, sharedInventory.getList(inventoryItemStacks), server.getRegistryManager());
+        try (FileOutputStream inventoryFileOutputStream = new FileOutputStream(inventoryFile);
+             DataOutputStream inventoryFileDataOutput = new DataOutputStream(inventoryFileOutputStream)) {
+            inventoryFile.createNewFile();
+            NbtIo.writeCompressed(nbt, inventoryFileDataOutput);
+        } catch (Exception e) {
+            LOGGER.error("Error while saving Shared Ender Chest: " + e);
+        }
+    }
+
+    public static void openSharedEnderChest(PlayerEntity player, World world, BlockPos pos) {
+        fakeEnderChestOpen(world, pos, true);
+        sharedInventory.openedEnderChests.put(player, pos);
+        player.openHandledScreen(new SimpleNamedScreenHandlerFactory((int_1, playerInventory, playerEntity) ->
+                new GenericContainerScreenHandler(getConfig().screenHandlerType(), int_1, playerInventory, sharedInventory, getConfig().sharedEnderChestRows), Text.of(getConfig().sharedEnderChestName)));
+    }
+
+    public static void playEnderChestOpenSound(World world, BlockPos pos) {
+        world.playSound(null, pos, SoundEvents.BLOCK_ENDER_CHEST_OPEN, SoundCategory.BLOCKS, 0.5F, world.random.nextFloat() * 0.1F + 0.9F);
+    }
+
+    public static void playEnderChestCloseSound(World world, BlockPos pos) {
+        world.playSound(null, pos, SoundEvents.BLOCK_ENDER_CHEST_CLOSE, SoundCategory.BLOCKS, 0.5F, world.random.nextFloat() * 0.1F + 0.9F);
+    }
+
+    public static void fakeEnderChestOpen(World world, BlockPos pos, boolean open) {
+        if (!(world.getBlockState(pos).getBlock() instanceof EnderChestBlock)) {
+            return;
+        }
+
+        if (open)
+            playEnderChestOpenSound(world, pos);
+        else
+            playEnderChestCloseSound(world, pos);
+        world.addSyncedBlockEvent(pos, Blocks.ENDER_CHEST, 1, open ? 1 : 0);
+    }
+
+    private static File getFile(MinecraftServer server) {
+        return server.getSavePath(WorldSavePath.ROOT).resolve("sharedenderchest.sav").toFile();
+    }
+
     public void onServerStarted(MinecraftServer server) {
         File inventoryFile = getFile(server);
         if (inventoryFile.exists()) {
@@ -55,19 +97,6 @@ public class SharedEnderChest implements ServerLifecycleEvents.ServerStopping, S
         }
     }
 
-    public static void saveInventory(MinecraftServer server) {
-        File inventoryFile = getFile(server);
-        NbtCompound nbt = new NbtCompound();
-        DefaultedList<ItemStack> inventoryItemStacks = DefaultedList.ofSize(getConfig().sharedEnderChestRows * 9, ItemStack.EMPTY);
-        Inventories.writeNbt(nbt, sharedInventory.getList(inventoryItemStacks), server.getRegistryManager());
-        try (FileOutputStream inventoryFileOutputStream = new FileOutputStream(inventoryFile);
-             DataOutputStream inventoryFileDataOutput = new DataOutputStream(inventoryFileOutputStream)) {
-            inventoryFile.createNewFile();
-            NbtIo.writeCompressed(nbt, inventoryFileDataOutput);
-        } catch (Exception e) {
-            LOGGER.error("Error while saving Shared Ender Chest: " + e);
-        }
-    }
     public void onServerStopping(MinecraftServer server) {
         saveInventory(server);
     }
@@ -88,15 +117,13 @@ public class SharedEnderChest implements ServerLifecycleEvents.ServerStopping, S
                 if (!player.isSpectator()) {
                     if (!getConfig().sharedEnderChestLimitedAccess) {
                         if (world.isClient()) return ActionResult.SUCCESS;
-                        playEnderChestOpenSound(world, hitResult.getBlockPos());
-                        openSharedEnderChest(player);
+                        openSharedEnderChest(player, world, hitResult.getBlockPos());
                         return ActionResult.SUCCESS;
                     } else {
                         for (String name : getConfig().sharedEnderChestNames) {
                             if (name.toLowerCase().strip().equalsIgnoreCase(player.getNameForScoreboard().toLowerCase())) {
                                 if (world.isClient()) return ActionResult.SUCCESS;
-                                playEnderChestOpenSound(world, hitResult.getBlockPos());
-                                openSharedEnderChest(player);
+                                openSharedEnderChest(player, world, hitResult.getBlockPos());
                                 return ActionResult.SUCCESS;
                             }
                         }
@@ -113,17 +140,4 @@ public class SharedEnderChest implements ServerLifecycleEvents.ServerStopping, S
 
     }
 
-    public static void openSharedEnderChest(PlayerEntity player) {
-        player.openHandledScreen(new SimpleNamedScreenHandlerFactory((int_1, playerInventory, playerEntity) ->
-                new GenericContainerScreenHandler(getConfig().screenHandlerType(), int_1, playerInventory, sharedInventory, getConfig().sharedEnderChestRows), Text.of(getConfig().sharedEnderChestName)));
-    }
-
-    public static void playEnderChestOpenSound(World world, BlockPos pos) {
-        world.playSound(null, pos, SoundEvents.BLOCK_ENDER_CHEST_OPEN, SoundCategory.BLOCKS, 0.5F, world.random.nextFloat() * 0.1F + 0.9F);
-    }
-
-    private static File getFile(MinecraftServer server) {
-        return server.getSavePath(WorldSavePath.ROOT).resolve("sharedenderchest.sav").toFile();
-    }
-
 }

src/main/java/wtf/hak/survivalfabric/features/sharedenderchest/SharedInventory.java

@@ -1,13 +1,18 @@
-package wtf.hak.survivalfabric.sharedenderchest;
+package wtf.hak.survivalfabric.features.sharedenderchest;
 
 import net.minecraft.entity.player.PlayerEntity;
 import net.minecraft.inventory.Inventories;
 import net.minecraft.inventory.Inventory;
 import net.minecraft.item.ItemStack;
 import net.minecraft.util.collection.DefaultedList;
+import net.minecraft.util.math.BlockPos;
+
+import java.util.HashMap;
+import java.util.Map;
 
 public class SharedInventory implements Inventory {
 
+    public final Map<PlayerEntity, BlockPos> openedEnderChests = new HashMap<>();
     private final DefaultedList<ItemStack> stacks;
 
     public SharedInventory(int inventoryRows) {
@@ -52,8 +57,7 @@ public class SharedInventory implements Inventory {
 
     @Override
     public ItemStack removeStack(int int_1, int int_2) {
-        ItemStack itemStack_1 = Inventories.splitStack(this.stacks, int_1, int_2);
-        return itemStack_1;
+        return Inventories.splitStack(this.stacks, int_1, int_2);
     }
 
     @Override
@@ -80,4 +84,12 @@ public class SharedInventory implements Inventory {
     public void clear() {
         stacks.clear();
     }
+
+    @Override
+    public void onClose(PlayerEntity player) {
+        BlockPos pos = openedEnderChests.remove(player);
+        if (openedEnderChests.containsValue(pos))
+            return;
+        SharedEnderChest.fakeEnderChestOpen(player.getWorld(), pos, false);
+    }
 }

src/main/java/wtf/hak/survivalfabric/features/veinminer/Drill.java

@@ -1,10 +1,12 @@
-package wtf.hak.survivalfabric.veinminer;
+package wtf.hak.survivalfabric.features.veinminer;
 
 import net.minecraft.block.BlockState;
 import net.minecraft.util.math.BlockPos;
 
 public interface Drill {
     boolean canHandle(BlockState blockState);
+
     boolean isRightTool(BlockPos pos);
+
     boolean drill(BlockPos blockPos);
 }

src/main/java/wtf/hak/survivalfabric/features/veinminer/VeinMinerEvents.java

@@ -1,15 +1,14 @@
-package wtf.hak.survivalfabric.veinminer;
+package wtf.hak.survivalfabric.features.veinminer;
 
 import net.minecraft.block.BlockState;
 import net.minecraft.entity.Entity;
-import net.minecraft.registry.Registries;
 import net.minecraft.server.network.ServerPlayerEntity;
 import net.minecraft.server.world.ServerWorld;
 import net.minecraft.util.math.BlockPos;
 import net.minecraft.world.World;
-import wtf.hak.survivalfabric.veinminer.drills.LeavesDrill;
-import wtf.hak.survivalfabric.veinminer.drills.OreDrill;
-import wtf.hak.survivalfabric.veinminer.drills.WoodDrill;
+import wtf.hak.survivalfabric.features.veinminer.drills.LeavesDrill;
+import wtf.hak.survivalfabric.features.veinminer.drills.OreDrill;
+import wtf.hak.survivalfabric.features.veinminer.drills.WoodDrill;
 
 public class VeinMinerEvents {
 
@@ -25,8 +24,7 @@ public class VeinMinerEvents {
             boolean shouldContinue = !mine(session);
             session.finish();
             return shouldContinue;
-        }
-        else {
+        } else {
             return true;
         }
     }

src/main/java/wtf/hak/survivalfabric/features/veinminer/VeinMinerSession.java

@@ -1,21 +1,29 @@
-package wtf.hak.survivalfabric.veinminer;
-
-import java.util.ArrayList;
-import java.util.HashSet;
-import java.util.Set;
+package wtf.hak.survivalfabric.features.veinminer;
 
 import net.minecraft.server.network.ServerPlayerEntity;
 import net.minecraft.server.world.ServerWorld;
 import net.minecraft.util.math.BlockPos;
 
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.Set;
+
 public class VeinMinerSession {
-    private static ArrayList<VeinMinerSession> sessions = new ArrayList<>();
+    private static final ArrayList<VeinMinerSession> sessions = new ArrayList<>();
 
     public ServerPlayerEntity player;
     public ServerWorld world;
     public Set<BlockPos> positions;
     public BlockPos initialPos;
 
+    private VeinMinerSession(ServerPlayerEntity player, ServerWorld world, BlockPos initialPos) {
+        this.player = player;
+        this.world = world;
+        this.initialPos = initialPos;
+        this.positions = new HashSet<>();
+        positions.add(initialPos);
+    }
+
     public static VeinMinerSession sessionForPlayer(ServerPlayerEntity player) {
         for (var session : sessions) {
             if (session.player == player) {
@@ -44,14 +52,6 @@ public class VeinMinerSession {
         sessions.remove(session);
     }
 
-    private VeinMinerSession(ServerPlayerEntity player, ServerWorld world, BlockPos initialPos) {
-        this.player = player;
-        this.world = world;
-        this.initialPos = initialPos;
-        this.positions = new HashSet<>();
-        positions.add(initialPos);
-    }
-
     public void addPosition(BlockPos pos) {
         positions.add(pos);
     }

src/main/java/wtf/hak/survivalfabric/features/veinminer/drills/DrillBase.java

@@ -1,15 +1,15 @@
-package wtf.hak.survivalfabric.veinminer.drills;
+package wtf.hak.survivalfabric.features.veinminer.drills;
+
 import net.minecraft.block.BlockState;
-
-import java.util.ArrayList;
-
 import net.minecraft.server.network.ServerPlayerEntity;
 import net.minecraft.text.MutableText;
 import net.minecraft.text.PlainTextContent;
 import net.minecraft.text.Text;
 import net.minecraft.util.math.BlockPos;
-import wtf.hak.survivalfabric.veinminer.Drill;
-import wtf.hak.survivalfabric.veinminer.VeinMinerSession;
+import wtf.hak.survivalfabric.features.veinminer.Drill;
+import wtf.hak.survivalfabric.features.veinminer.VeinMinerSession;
+
+import java.util.ArrayList;
 
 import static wtf.hak.survivalfabric.SurvivalFabric.LOGGER;
 
@@ -37,14 +37,6 @@ public class DrillBase implements Drill {
         return session.player.getMainHandStack().isSuitableFor(blockState);
     }
 
-    protected interface ForXYZHandler {
-        public void handle(BlockPos pos);
-    }
-
-    protected interface ForXYZCounter {
-        public int handle(BlockPos pos);
-    }
-
     protected void forXYZ(BlockPos pos, int max, ForXYZHandler handler) {
         forXYZ(pos, max, handlerPos -> {
             handler.handle(handlerPos);
@@ -75,20 +67,17 @@ public class DrillBase implements Drill {
         String[] order = new String[]{"x", "y", "z"};
         if (forceVertical) {
             order = new String[]{"y", "x", "z"};
-        }
-        else {
+        } else {
             ServerPlayerEntity player = session.player;
             boolean majorPitchChange = player.getPitch() < -45.0 || player.getPitch() > 45.0;
             boolean majorYawChange = (player.getYaw() > 45.0 && player.getYaw() < 135.0) || (player.getYaw() < -45.0 && player.getYaw() > -135.0);
             if (majorPitchChange) {
                 if (majorYawChange) {
                     order = new String[]{"y", "z", "x"};
-                }
-                else {
+                } else {
                     order = new String[]{"y", "x", "z"};
                 }
-            }
-            else {
+            } else {
                 if (majorYawChange) {
                     order = new String[]{"z", "y", "x"};
                 }
@@ -130,4 +119,12 @@ public class DrillBase implements Drill {
         session.player.sendMessage(text);
         LOGGER.info(message);
     }
+
+    protected interface ForXYZHandler {
+        void handle(BlockPos pos);
+    }
+
+    protected interface ForXYZCounter {
+        int handle(BlockPos pos);
+    }
 }

src/main/java/wtf/hak/survivalfabric/features/veinminer/drills/LeavesDrill.java

@@ -1,4 +1,4 @@
-package wtf.hak.survivalfabric.veinminer.drills;
+package wtf.hak.survivalfabric.features.veinminer.drills;
 
 import net.minecraft.block.Block;
 import net.minecraft.block.BlockState;
@@ -7,7 +7,7 @@ import net.minecraft.registry.tag.TagKey;
 import net.minecraft.server.world.ServerWorld;
 import net.minecraft.util.Identifier;
 import net.minecraft.util.math.BlockPos;
-import wtf.hak.survivalfabric.veinminer.VeinMinerSession;
+import wtf.hak.survivalfabric.features.veinminer.VeinMinerSession;
 
 import java.util.ArrayDeque;
 
@@ -15,12 +15,12 @@ import static wtf.hak.survivalfabric.config.ConfigManager.getConfig;
 
 public class LeavesDrill extends DrillBase {
 
+    public static final TagKey<Block> leavesTag = TagKey.of(RegistryKeys.BLOCK, Identifier.of("survivalfabric", "leaves"));
+
     public LeavesDrill(VeinMinerSession session) {
         super(session);
     }
 
-    public static final TagKey<Block> leavesTag = TagKey.of(RegistryKeys.BLOCK, Identifier.of("survivalfabric", "leaves"));
-
     @Override
     public boolean canHandle(BlockState blockState) {
         return blockState.isIn(leavesTag);

src/main/java/wtf/hak/survivalfabric/features/veinminer/drills/OreDrill.java

@@ -1,4 +1,4 @@
-package wtf.hak.survivalfabric.veinminer.drills;
+package wtf.hak.survivalfabric.features.veinminer.drills;
 
 import net.minecraft.block.Block;
 import net.minecraft.block.BlockState;
@@ -6,23 +6,21 @@ import net.minecraft.registry.RegistryKeys;
 import net.minecraft.registry.tag.TagKey;
 import net.minecraft.server.world.ServerWorld;
 import net.minecraft.util.Identifier;
+import net.minecraft.util.math.BlockPos;
+import wtf.hak.survivalfabric.features.veinminer.VeinMinerSession;
 
 import java.util.ArrayDeque;
 
-import net.minecraft.registry.Registries;
-import net.minecraft.util.math.BlockPos;
-import wtf.hak.survivalfabric.veinminer.VeinMinerSession;
-
 import static wtf.hak.survivalfabric.config.ConfigManager.getConfig;
 
 public class OreDrill extends DrillBase {
 
+    public static final TagKey<Block> oreTag = TagKey.of(RegistryKeys.BLOCK, Identifier.of("survivalfabric", "ore"));
+
     public OreDrill(VeinMinerSession session) {
         super(session);
     }
 
-    public static final TagKey<Block> oreTag = TagKey.of(RegistryKeys.BLOCK, Identifier.of("survivalfabric", "ore"));
-
     @Override
     public boolean canHandle(BlockState blockState) {
         return blockState.isIn(oreTag);

src/main/java/wtf/hak/survivalfabric/features/veinminer/drills/WoodDrill.java

@@ -1,29 +1,27 @@
-package wtf.hak.survivalfabric.veinminer.drills;
+package wtf.hak.survivalfabric.features.veinminer.drills;
 
+import net.minecraft.block.Block;
 import net.minecraft.block.BlockState;
+import net.minecraft.registry.Registries;
 import net.minecraft.registry.RegistryKeys;
 import net.minecraft.registry.tag.TagKey;
 import net.minecraft.server.world.ServerWorld;
 import net.minecraft.util.Identifier;
-
+import net.minecraft.util.math.BlockPos;
+import wtf.hak.survivalfabric.features.veinminer.VeinMinerSession;
 
 import java.util.ArrayDeque;
 
-import net.minecraft.block.Block;
-import net.minecraft.registry.Registries;
-import net.minecraft.util.math.BlockPos;
-import wtf.hak.survivalfabric.veinminer.VeinMinerSession;
-
 import static wtf.hak.survivalfabric.config.ConfigManager.getConfig;
 
 public class WoodDrill extends DrillBase {
 
+    public static final TagKey<Block> woodTag = TagKey.of(RegistryKeys.BLOCK, Identifier.of("survivalfabric", "wood"));
+
     public WoodDrill(VeinMinerSession session) {
         super(session);
     }
 
-    public static final TagKey<Block> woodTag = TagKey.of(RegistryKeys.BLOCK, Identifier.of("survivalfabric", "wood"));
-
     @Override
     public boolean canHandle(BlockState blockState) {
         return blockState.isIn(woodTag);
@@ -33,8 +31,8 @@ public class WoodDrill extends DrillBase {
     public boolean drill(BlockPos startPos) {
         ServerWorld world = session.world;
         int broken = 0;
-        ArrayDeque<BlockPos> pendingLogs = new ArrayDeque<BlockPos>();
-        ArrayDeque<BlockPos> logBlocks = new ArrayDeque<BlockPos>();
+        ArrayDeque<BlockPos> pendingLogs = new ArrayDeque<>();
+        ArrayDeque<BlockPos> logBlocks = new ArrayDeque<>();
         pendingLogs.add(startPos);
 
         String leavesBlockId = Registries.BLOCK.getId(world.getBlockState(startPos).getBlock()).toString().replace("_log", "_leaves");
@@ -57,11 +55,8 @@ public class WoodDrill extends DrillBase {
             }
         }
 
-        // second round, leaves
-        // The pending blocks are all air now,
         ArrayDeque<BlockPos> pendingLeaves = logBlocks;
         while (!pendingLeaves.isEmpty() && broken < getConfig().maxVeinSize) {
-            // remove the immediately surrounding leaves around the log blocks
             broken += forXYZ(pendingLeaves.remove(), 1, newPos -> {
                 int brokenLeaves = 0;
                 Block newBlock = world.getBlockState(newPos).getBlock();

src/main/java/wtf/hak/survivalfabric/mixin/PlayerManagerMixin.java

@@ -1,10 +1,8 @@
 package wtf.hak.survivalfabric.mixin;
 
-import com.mojang.authlib.minecraft.client.MinecraftClient;
 import net.minecraft.network.ClientConnection;
 import net.minecraft.network.message.MessageType;
 import net.minecraft.network.message.SignedMessage;
-import net.minecraft.server.MinecraftServer;
 import net.minecraft.server.PlayerManager;
 import net.minecraft.server.network.ConnectedClientData;
 import net.minecraft.server.network.ServerPlayerEntity;
@@ -18,9 +16,6 @@ import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
 import wtf.hak.survivalfabric.commands.SpectatorCommand;
 import wtf.hak.survivalfabric.config.ConfigManager;
 
-import java.awt.*;
-import java.beans.Expression;
-import java.util.Objects;
 import java.util.Set;
 
 @Mixin(PlayerManager.class)
@@ -62,7 +57,8 @@ public abstract class PlayerManagerMixin {
                     String result = String.valueOf(evaluateExpression(expression));
                     if (rawMessage.contains(" ")) rawMessage += " ";
                     rawMessage += (result.endsWith(".0")) ? result.substring(0, result.length() - 2) : result;
-                } catch (Exception e) {}
+                } catch (Exception e) {
+                }
             }
             Text text = Text.literal(String.format(ConfigManager.getConfig().chatMessage, sender.getName().getString(), rawMessage));
             sender.getServer().getPlayerManager().broadcast(text, false);
@@ -78,7 +74,8 @@ public abstract class PlayerManagerMixin {
                     Text formattedMessage = Text.literal("<" + sender.getName().getString() + "> " + rawMessage);
                     sender.getServer().getPlayerManager().broadcast(formattedMessage, false);
                     ci.cancel();
-                } catch (Exception e) {}
+                } catch (Exception e) {
+                }
             }
         }
     }

src/main/java/wtf/hak/survivalfabric/mixin/ServerWorldMixin.java

@@ -7,7 +7,7 @@ import org.spongepowered.asm.mixin.Mixin;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Inject;
 import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
-import wtf.hak.survivalfabric.utils.Utils;
+import wtf.hak.survivalfabric.utils.PacketUtils;
 
 @Mixin(ServerWorld.class)
 public class ServerWorldMixin {
@@ -15,7 +15,7 @@ public class ServerWorldMixin {
     @Inject(method = "onDimensionChanged", at = {@At("HEAD")})
     public void onDimensionChange(Entity entity, CallbackInfo ci) {
         if (entity instanceof ServerPlayerEntity) {
-            Utils.updateListNames((ServerPlayerEntity)entity);
+            PacketUtils.updateListNames((ServerPlayerEntity) entity);
         }
     }
 }

src/main/java/wtf/hak/survivalfabric/utils/PacketUtils.java

@@ -5,7 +5,7 @@ import net.minecraft.server.network.ServerPlayerEntity;
 
 import java.util.Objects;
 
-public class Utils {
+public class PacketUtils {
 
     public static void updateListNames(ServerPlayerEntity p) {
         for (ServerPlayerEntity sp : Objects.requireNonNull(p.getServer()).getPlayerManager().getPlayerList()) {